Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timeline): fix chart can't work when axis line is not shown #17647

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix a bug that the chart can't work when the axis line is not shown.

Fixed issues

Details

Before: What was the problem?

The chart throws NPE errors.

Error: TypeError: Cannot read property 'shape' of undefined at SliderTimelineView._pointerChangeTimeline

image

After: How does it behave after the fixing?

See the screenshot above.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the first case in test/timeline-case.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Sep 14, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart added this to the 5.4.1 milestone Sep 14, 2022
@Ovilia Ovilia merged commit c9e9a02 into master Sep 14, 2022
@echarts-bot
Copy link

echarts-bot bot commented Sep 14, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The timeline drag becomes invalid after checkpoint is clicked
2 participants