Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): add missing type number to emphasis.scale for scatter/line/graph series #17390

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Jul 18, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

PR #16688 allows customizing the scale size of the symbol, but it is only for the EffectScatter series. In fact, this new feature is suitable for the symbol of all series. So this PR is to add the missing type to the Scatter, Line, and Graph series.

Fixed issues

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 18, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart requested review from susiwen8 and pissang July 18, 2022 04:48
@plainheart plainheart added this to the 5.4 milestone Jul 18, 2022
@plainheart plainheart merged commit 65d867e into master Jul 19, 2022
@plainheart plainheart deleted the fix/symbol-scale-types branch July 19, 2022 07:41
@echarts-bot
Copy link

echarts-bot bot commented Jul 19, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia modified the milestones: 5.4, 5.4.0 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants