Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(treemap.breadcrumb): add emphasis state #17242

Merged
merged 6 commits into from
Jun 21, 2022
Merged

feat(treemap.breadcrumb): add emphasis state #17242

merged 6 commits into from
Jun 21, 2022

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Jun 18, 2022 •
edited by Ovilia
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add emphasis state to breadcrumb

Fixed issues

Details

Before: What was the problem?

Kapture 2022-06-18 at 17 46 59

After: How does it behave after the fixing?

Kapture 2022-06-18 at 17 44 59

Document Info

One of the following should be checked.

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

test/treemap-simple.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 18, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@susiwen8 susiwen8 mentioned this pull request Jun 18, 2022
Closed
@susiwen8 susiwen8 requested a review from pissang June 18, 2022 09:49
@susiwen8 susiwen8 added this to the 5.4 milestone Jun 18, 2022
@susiwen8 susiwen8 requested a review from plainheart June 18, 2022 09:49
@susiwen8 susiwen8 requested a review from pissang June 19, 2022 11:47
plainheart
plainheart reviewed Jun 19, 2022
View reviewed changes
src/chart/treemap/TreemapSeries.ts Outdated Show resolved Hide resolved
src/chart/treemap/Breadcrumb.ts Outdated Show resolved Hide resolved
src/chart/treemap/Breadcrumb.ts Outdated Show resolved Hide resolved
src/chart/treemap/Breadcrumb.ts Outdated
Comment on lines 204 to 206
toggleHoverEmphasis(
el, 'self', 'global', emphasisModel.get('disabled')
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would be great If we could support focus & blur so that related nodes can be highlighted or downplayed when hovering on the breadcrumb item. Just like this,

img

Of course, I know this is optional.

@echarts-bot
Copy link

echarts-bot bot commented Jun 19, 2022

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@plainheart plainheart added the PR: awaiting doc Document changes is required for this PR. label Jun 19, 2022
@susiwen8 susiwen8 requested a review from plainheart June 20, 2022 14:57
plainheart
plainheart reviewed Jun 20, 2022
View reviewed changes
src/chart/treemap/Breadcrumb.ts Outdated Show resolved Hide resolved
src/chart/treemap/Breadcrumb.ts Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from plainheart June 20, 2022 15:12
plainheart
plainheart previously approved these changes Jun 20, 2022
View reviewed changes
src/chart/treemap/Breadcrumb.ts Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from plainheart June 20, 2022 15:33
plainheart
plainheart approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :)

@susiwen8 susiwen8 merged commit bafb0f9 into apache:master Jun 21, 2022
@susiwen8 susiwen8 deleted the 15741 branch June 21, 2022 07:14
@echarts-bot
Copy link

echarts-bot bot commented Jun 21, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia modified the milestones: 5.4, 5.4.0 Sep 1, 2022
@echarts-bot echarts-bot bot added PR: awaiting review PR: doc unchanged and removed PR: awaiting doc Document changes is required for this PR. labels Sep 16, 2022
@susiwen8 susiwen8 mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plainheart plainheart plainheart approved these changes

@pissang pissang Awaiting requested review from pissang

Assignees
No one assigned
Labels
PR: author is committer PR: awaiting review PR: doc ready size/M
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

Breadcrumb emphasis in treemap has no effect
4 participants
@susiwen8 @pissang @plainheart @Ovilia