Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix SunburstSeriesOption and TreemapSeriesOption types #17218

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

dmzc
Copy link

@dmzc dmzc commented Jun 15, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix interface SunburstSeriesOption and TreemapSeriesOption .

Fixed issues

No issue.

Details

Before: What was the problem?

Sunburst and Treemap supports the option nodeClick=false as document described.
But,the interface SunburstSeriesOption and TreemapSeriesOption is inaccurate.

image
image

After: How does it behave after the fixing?

Add the false to the interface SunburstSeriesOption.nodeClick and TreemapSeriesOption.nodeClick.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 15, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang added this to the 5.4 milestone Jun 15, 2022
@Ovilia Ovilia changed the title fix:improve interface SunburstSeriesOption and TreemapSeriesOption fix(types): fix SunburstSeriesOption and TreemapSeriesOption types Jun 16, 2022
@Ovilia Ovilia merged commit 18c3337 into apache:master Jun 16, 2022
@echarts-bot
Copy link

echarts-bot bot commented Jun 16, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia modified the milestones: 5.4, 5.4.0 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants