Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie): support specifying coordinate system for pie series. #17132

Merged
merged 2 commits into from
Aug 14, 2022

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented May 28, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. Add coordinate system support for pie series.
  2. BMap extension supports convertToPixel & convertFromPixel API.

Fixed issues

Details

Before: What was the problem?

It's not convenient and not direct to display the pie series on Geo/BMap/AMap/Calendar coordinate system.

After: How is it fixed in this PR?

Add a new option coordinateSystem for pie series.

Preview

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/pie-coordinate-system.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented May 28, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@pull-request-size pull-request-size bot added size/M and removed size/S labels May 28, 2022
@plainheart plainheart requested a review from pissang May 28, 2022 08:19
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This looks very promising! 💐

@plainheart
Copy link
Member Author

@Ovilia @pissang Is this feature planned in v5.3.3 or v5.4?

@pissang
Copy link
Contributor

pissang commented Jun 7, 2022

This feature deserved to be introduced as an important feature in the 5.4 article. But I also can't wait to have it in our next version. @plainheart I think I will leave this decision to you:)

@plainheart
Copy link
Member Author

I had planned to release a new version of the amap extension for this feature in response to some developers' feedback. But it sounds better to introduce this feature in v5.4 so that the developer can know about it in time. I'm okay to leave it in v5.4. :D

@susiwen8 susiwen8 added this to the 5.4 milestone Jun 13, 2022
@plainheart plainheart requested review from pissang and removed request for pissang August 13, 2022 02:25
@echarts-bot
Copy link

echarts-bot bot commented Aug 13, 2022

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@plainheart plainheart merged commit 9bcded1 into master Aug 14, 2022
@plainheart plainheart deleted the feat/pie-coordinate-system branch August 14, 2022 08:54
@echarts-bot
Copy link

echarts-bot bot commented Aug 14, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants