-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie): support specifying coordinate system for pie series. #17132
Conversation
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This looks very promising! 💐
This feature deserved to be introduced as an important feature in the 5.4 article. But I also can't wait to have it in our next version. @plainheart I think I will leave this decision to you:) |
I had planned to release a new version of the amap extension for this feature in response to some developers' feedback. But it sounds better to introduce this feature in v5.4 so that the developer can know about it in time. I'm okay to leave it in v5.4. :D |
To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
convertToPixel
&convertFromPixel
API.Fixed issues
Details
Before: What was the problem?
It's not convenient and not direct to display the pie series on Geo/BMap/AMap/Calendar coordinate system.
After: How is it fixed in this PR?
Add a new option
coordinateSystem
for pie series.Preview
Misc
Related test cases or examples to use the new APIs
Please refer to
test/pie-coordinate-system.html
Others
Merging options
Other information