Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataZoom): fix borderColor may not work in some bundle environments #16854

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

Ling310
Copy link

@Ling310 Ling310 commented Apr 8, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

#16849

Details

Before: What was the problem?

dataZoom.borderColor not work
image

After: How is it fixed in this PR?

dataZoom.borderColor work

image

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Apr 8, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

plainheart
plainheart previously approved these changes Apr 8, 2022
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I checked the minimized script and found it was correctly compressed. It might be because your bundler or minimizer can't handle such a comment. Anyway, this kind of inline comment is not very regular in my view. It should be /* COMMENT */ at least.

@plainheart plainheart added this to the 5.3.3 milestone Apr 8, 2022
@plainheart
Copy link
Member

plainheart commented Apr 8, 2022

Just found it may be confusing if we put this comment on this line. @Ling310 Could you please move it to the previous line?

@Ling310
Copy link
Author

Ling310 commented Apr 12, 2022

ok,I will remove this comment,and make a new PR

@pissang
Copy link
Contributor

pissang commented Apr 12, 2022

@Ling310 No need to create a new PR. Just push a commit to fix it.

@Ling310
Copy link
Author

Ling310 commented Apr 12, 2022

changed: 1b9afd8

@plainheart plainheart merged commit 2a67f86 into apache:master Apr 12, 2022
@echarts-bot
Copy link

echarts-bot bot commented Apr 12, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart changed the title fix: bug 16849 fix(dataZoom): fix borderColor may not work in some bundle environments Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dataZoom.borderColor can't work when import ECharts lib as isn't build code
3 participants