-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dataZoom): fix borderColor may not work in some bundle environments #16854
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I checked the minimized script and found it was correctly compressed. It might be because your bundler or minimizer can't handle such a comment. Anyway, this kind of inline comment is not very regular in my view. It should be /* COMMENT */
at least.
Just found it may be confusing if we put this comment on this line. @Ling310 Could you please move it to the previous line? |
ok,I will remove this comment,and make a new PR |
@Ling310 No need to create a new PR. Just push a commit to fix it. |
4e3fc0e
to
1b9afd8
Compare
changed: 1b9afd8 |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
#16849
Details
Before: What was the problem?
dataZoom.borderColor not work
After: How is it fixed in this PR?
dataZoom.borderColor work
Misc
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information