-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prepareCustoms key for Single axis. #16850
Fix prepareCustoms key for Single axis. #16850
Conversation
Thanks for your contribution! |
@benlongo Thanks for the contribution and LGTM!. Adding a new test case for this fix will be great! You can append this test case to |
9c5482a
to
5a6bdf0
Compare
5a6bdf0
to
b66d3d2
Compare
b66d3d2
to
9b670a0
Compare
Sorry for the long delay! I've added a test and confirmed that it is broken on master and that this branch fixes it. I additionally fixed a typo I came across but can pull that into a separate PR if you prefer. I modified an existing example to reproduce the bug, which isn't a minimal, but I can make it simpler if required. |
@benlongo It's fine. All looks good! Well done! |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
When using a custom series with a single axis, a lookup on
prepareCustoms
fails as it is looking forsingle
instead ofsingleAxis
.Fixed issues
Related test cases or examples to use the new APIs
If this is the right approach to fixing this, I can put together a reproduction and test for it.