Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prepareCustoms key for Single axis. #16850

Merged
merged 3 commits into from
May 20, 2022

Conversation

benlongo
Copy link
Contributor

@benlongo benlongo commented Apr 7, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

When using a custom series with a single axis, a lookup on prepareCustoms fails as it is looking for single instead of singleAxis.

Fixed issues

  • custom series on single axis now works

Related test cases or examples to use the new APIs

If this is the right approach to fixing this, I can put together a reproduction and test for it.

@echarts-bot
Copy link

echarts-bot bot commented Apr 7, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

pissang
pissang previously approved these changes Apr 9, 2022
@pissang pissang added this to the 5.3.3 milestone Apr 9, 2022
@pissang
Copy link
Contributor

pissang commented Apr 9, 2022

@benlongo Thanks for the contribution and LGTM!. Adding a new test case for this fix will be great! You can append this test case to test/custom.html

@benlongo benlongo force-pushed the fix_prepareCustoms_for_single_axis branch from 9c5482a to 5a6bdf0 Compare May 19, 2022 20:55
@benlongo benlongo force-pushed the fix_prepareCustoms_for_single_axis branch from 5a6bdf0 to b66d3d2 Compare May 19, 2022 20:57
@benlongo benlongo force-pushed the fix_prepareCustoms_for_single_axis branch from b66d3d2 to 9b670a0 Compare May 20, 2022 03:31
@benlongo
Copy link
Contributor Author

benlongo commented May 20, 2022

Sorry for the long delay! I've added a test and confirmed that it is broken on master and that this branch fixes it. I additionally fixed a typo I came across but can pull that into a separate PR if you prefer.

I modified an existing example to reproduce the bug, which isn't a minimal, but I can make it simpler if required.

@benlongo benlongo requested a review from pissang May 20, 2022 03:40
@pissang
Copy link
Contributor

pissang commented May 20, 2022

@benlongo It's fine. All looks good! Well done!

@pissang pissang merged commit 99b0182 into apache:master May 20, 2022
@echarts-bot
Copy link

echarts-bot bot commented May 20, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@benlongo benlongo deleted the fix_prepareCustoms_for_single_axis branch May 20, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants