Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(labelLine): update labelLine ignore #16542

Merged
merged 3 commits into from
Mar 24, 2022
Merged

fix(labelLine): update labelLine ignore #16542

merged 3 commits into from
Mar 24, 2022

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Feb 18, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

It should update ignore

Fixed issues

Details

Before: What was the problem?

Kapture 2022-02-19 at 00 11 55

After: How is it fixed in this PR?

Kapture 2022-02-19 at 00 09 51

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

pie-label.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 18, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang
Copy link
Contributor

pissang commented Mar 24, 2022

Sorry for the late review.

The ignore property of label and labelLine is updated in

stateObj.ignore = !stateShow;

stateObj.ignore = true;

Especially the labelLine, it has complex logic to determine if it can be shown when label is not shown. But for some reason it fails when switching from show to hide in the emphasis state.

@susiwen8
Copy link
Contributor Author

@pissang Thanks for the pointer

src/chart/pie/PieView.ts Outdated Show resolved Hide resolved
@pissang pissang added this to the 5.3.2 milestone Mar 24, 2022
@susiwen8 susiwen8 requested a review from pissang March 24, 2022 14:29
@pissang pissang merged commit 6c721de into apache:master Mar 24, 2022
@echarts-bot
Copy link

echarts-bot bot commented Mar 24, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the fix-16539 branch March 24, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] LabelLine doesn't hide
2 participants