-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(line): using sampling with lttb, NaN point should not be filtered. #16431
Conversation
Thanks for your contribution! |
Seems when I'm running visual regression test(which has roslution 830x750), the current behavior seems to having unexpected points in the null values.
Also I think we can add the case from https://codepen.io/tmscer/pen/yLgGXbo directly. |
fixed. Due to incorrect index order. |
Demo 1:
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
…. close #14689
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
Details
Before: What was the problem?
After: How is it fixed in this PR?
store NaN point, append first to every bucket, adjust Uint Array length.
Misc
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information