Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(line): using sampling with lttb, NaN point should not be filtered. #16431

Merged
merged 6 commits into from
Feb 18, 2022

Conversation

fuchunhui
Copy link
Contributor

…. close #14689

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Details

Before: What was the problem?

After: How is it fixed in this PR?

store NaN point, append first to every bucket, adjust Uint Array length.

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jan 26, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

src/data/DataStore.ts Outdated Show resolved Hide resolved
src/data/DataStore.ts Outdated Show resolved Hide resolved
src/data/DataStore.ts Outdated Show resolved Hide resolved
@pissang pissang added this to the 5.3.1 milestone Feb 15, 2022
@pissang
Copy link
Contributor

pissang commented Feb 16, 2022

Seems when I'm running visual regression test(which has roslution 830x750), the current behavior seems to having unexpected points in the null values.

Before After
image image

image

Also I think we can add the case from https://codepen.io/tmscer/pen/yLgGXbo directly.

@fuchunhui
Copy link
Contributor Author

Seems when I'm running visual regression test(which has roslution 830x750), the current behavior seems to having unexpected points in the null values.

Before After
image image
image

Also I think we can add the case from https://codepen.io/tmscer/pen/yLgGXbo directly.

fixed. Due to incorrect index order.

@fuchunhui
Copy link
Contributor Author

fuchunhui commented Feb 17, 2022

// set frameSize = 3;
const dimStore = [21, 22, 20, 33, 44, 55]; 
// IF result is [1, 5]

Demo 1:

const dimStore = [21, null, 20, 33, 44, 55]; 
// Right result is [0, 1, 5]
// Before, it would be [1, 0, 5], not right, this made the wrong case as you mentioned

@pissang

@pissang pissang merged commit fdfb46c into apache:master Feb 18, 2022
@echarts-bot
Copy link

echarts-bot bot commented Feb 18, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@fuchunhui fuchunhui deleted the fix-14689 branch March 16, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using sampling with connectNulls connects regular datapoints with null ones when zoomed out
2 participants