Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stacked bar in large mode. fix stacked bar on log axis. #16338

Merged
merged 4 commits into from
Jan 7, 2022
Merged

fix stacked bar in large mode. fix stacked bar on log axis. #16338

merged 4 commits into from
Jan 7, 2022

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Jan 7, 2022 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR fix complex layout of bar in large mode. For example when stack is enabled. Now bar layout is consistent in large and normal mode. This refactor also fixs stacked bar on log axis unconsciously

Also this PR did a little optimization that only call allLeaveBlur once if there are multiple highlight payload. It fixes the performance drop when doing highlight in hundreds of series.

Fixed issues

#16133
#14657

Details

Before: What was the problem?

After: How is it fixed in this PR?

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jan 7, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang changed the base branch from master to next January 7, 2022 05:52
@pissang pissang requested review from 100pah and plainheart January 7, 2022 05:52
@pissang pissang added this to the 5.3 milestone Jan 7, 2022
@pissang pissang requested review from Ovilia and susiwen8 January 7, 2022 06:01
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jan 7, 2022
Ovilia
Ovilia approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pissang pissang merged commit 0e44d83 into next Jan 7, 2022
@echarts-bot
Copy link

echarts-bot bot commented Jan 7, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the optimize-bar-performance branch January 7, 2022 07:09
@pissang pissang mentioned this pull request Jan 7, 2022
Closed
@pissang pissang changed the title fix stacked bar in large mode. fix stacked bar in large mode. fix stacked bar on log axis. Jan 7, 2022
This was referenced Mar 3, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia approved these changes

@100pah 100pah Awaiting requested review from 100pah

@plainheart plainheart Awaiting requested review from plainheart

@susiwen8 susiwen8 Awaiting requested review from susiwen8

Assignees
No one assigned
Labels
PR: author is committer size/XL
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@pissang @Ovilia