fix(dataview): hide tooltip when data view is open. #16321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of inset 5px to avoid click the below layers.
|
Thanks for your contribution! The pull request is marked to be |
pissang
reviewed
Jan 5, 2022
pissang
reviewed
Jan 5, 2022
| @@ -318,32 +318,40 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> { | |||
| private _dom: HTMLDivElement; | |||
|
|
|||
| onclick(ecModel: GlobalModel, api: ExtensionAPI) { | |||
| // FIXME: better way? | |||
| setTimeout(() => { | |||
There was a problem hiding this comment.
Is it necessary to use setTimeout? The tooltip should have been displayed before onclick event happens. I'm not sure if there is edge cases or something else I didn't thought of.
There was a problem hiding this comment.
The tooltip won't disappear if no delay. I don't know why yet.
pissang
approved these changes
Feb 15, 2022
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
|
Ooops. Forgot to retarget this PR to the master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
(1) Fix a bug that the tooltip won't be hidden when the data view is open.
(2) use 5px padding instead of inset 5px to avoid clicking the below layers.
Fixed issues
Details
Before: What was the problem?
The tooltip wasn't hidden after the data view was open.
After: How is it fixed in this PR?
Hide the tooltip after the data view is open.
Misc
Related test cases or examples to use the new APIs
Please refer to
test/toolbox-tooltip.htmlOthers
Merging options
Other information