-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie/sunburst): supports configuring any one border radius. #16298
Conversation
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the This PR depends on ZRender changes. Please update the ZRender dependency to the latest nightly version including this change, which takes place everyday at 8:00 UTC (16:00 Beijing Time). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@plainheart Do you mind adding user interactions record on the test? |
It seems if the To reproduce: chart.setOption({
series: [{
itemStyle: {
borderRadius: [0, 20, '50%']
}
}]
}); |
I think we can do percentage calculation in echarts and only support pixel value in zrender. |
@pissang Yeah. I'm doing so. |
@plainheart Please let me know if it's ready for next round review |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Enhance the border radius for pie series & sunburst series to allow the developer to configure any one border radius instead of a pair.
Details
Before: What was the problem?
After: How is it fixed in this PR?
Misc
Related test cases or examples to use the new APIs
Please refer to
test/pie-cornerRadius.html
.Others
Merging options
Other information