Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] dataZoom: optimize shadow render performance when roaming. #16070

Merged
merged 2 commits into from
Nov 16, 2021
Merged

[fix] dataZoom: optimize shadow render performance when roaming. #16070

merged 2 commits into from
Nov 16, 2021

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Nov 16, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. Avoid shadow re-render in slider dataZoom when roaming on the chart.
  2. Clear throttle timeouts when disposing.

Fixed issues

#15409

@echarts-bot
Copy link

echarts-bot bot commented Nov 16, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang requested a review from 100pah November 16, 2021 06:17
@pissang pissang merged commit 2b61e57 into master Nov 16, 2021
@pissang pissang deleted the optimize-dataZoom-shadow-performance branch November 16, 2021 10:31
@echarts-bot
Copy link

echarts-bot bot commented Nov 16, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang added this to the 5.3 milestone Nov 16, 2021
@pissang pissang mentioned this pull request Dec 1, 2021
Closed
@pissang pissang mentioned this pull request Jan 21, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100pah 100pah 100pah approved these changes

Assignees
No one assigned
Labels
PR: author is committer size/L
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@pissang @100pah