Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(axis): only value has scale in cartesian #15998

Merged
merged 5 commits into from
Nov 4, 2021
Merged

fix(axis): only value has scale in cartesian #15998

merged 5 commits into from
Nov 4, 2021

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Nov 2, 2021 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

According to doc
In catersain, only value axis can have scale.

Fixed issues

Details

Before: What was the problem?

Screen Shot 2021-11-02 at 11 19 24 PM

After: How is it fixed in this PR?

Screen Shot 2021-11-02 at 11 19 13 PM

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Nov 2, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@susiwen8 susiwen8 requested review from 100pah and pissang November 2, 2021 15:20
pissang
pissang reviewed Nov 3, 2021
View reviewed changes
src/coord/cartesian/AxisModel.ts Outdated Show resolved Hide resolved
src/coord/cartesian/AxisModel.ts Outdated Show resolved Hide resolved
src/coord/cartesian/AxisModel.ts Outdated Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from pissang November 3, 2021 14:33
pissang
pissang requested changes Nov 4, 2021
View reviewed changes
src/coord/cartesian/AxisModel.ts Outdated Show resolved Hide resolved
src/coord/axisCommonTypes.ts Outdated Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from pissang November 4, 2021 03:05
@pissang pissang merged commit a3b9496 into apache:master Nov 4, 2021
@echarts-bot
Copy link

echarts-bot bot commented Nov 4, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang added this to the 5.3 milestone Nov 4, 2021
@susiwen8 susiwen8 deleted the 10174 branch November 4, 2021 03:13
@susiwen8 susiwen8 mentioned this pull request Nov 4, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

@100pah 100pah Awaiting requested review from 100pah

Assignees
No one assigned
Labels
PR: author is committer size/S
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

log yAxis with scale
2 participants
@susiwen8 @pissang