-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pictorialBar): Fixed a problem with rendering incorrectly when data is 0 and borderWidth
is set to a non-0 value
#12793
fix(pictorialBar): Fixed a problem with rendering incorrectly when data is 0 and borderWidth
is set to a non-0 value
#12793
Conversation
Thanks for your contribution! |
borderWidth
is set to a non-0 value
这个bug什么时候会被修复?现在是12月10号,距离6月10号已经过去6个月了 |
Hi, @yanheSu Thanks for your contribution! I'm sorry for putting this matter on hold. Would you mind updating the codebase to the latest and resolving the conflicts? |
Okay, I will switch to the latest code base, resolve the conflict and push again |
3ab1341
to
140e0c3
Compare
@plainheart I have updated the code and resolved the conflict, and added test cases, please review again |
Is there any progress? |
LGTM. |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
fix zero data in pictorialbar can't render correct, when the borderWidth be setted.
Fixed issues
Details
Before: What was the problem?
I'm not exactly sure what
pxSign
really means, but it looks like a direction.when data is zero, then boundingLength is zero,
pxSign
will be zero, and then symbolScale will be zero too, and ifborderWidth
setted and not zero, thevalueLineWidth
will be NaN.After: How is it fixed in this PR?
pxSign
will be part of the denominator somewhere else, so it shouldn't be 0Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information