Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pictorialBar): Fixed a problem with rendering incorrectly when data is 0 and borderWidth is set to a non-0 value #12793

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

yanheSu
Copy link
Contributor

@yanheSu yanheSu commented Jun 10, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix zero data in pictorialbar can't render correct, when the borderWidth be setted.

Fixed issues

Details

Before: What was the problem?

I'm not exactly sure what pxSign really means, but it looks like a direction.
when data is zero, then boundingLength is zero, pxSign will be zero, and then symbolScale will be zero too, and if borderWidth setted and not zero, the valueLineWidth will be NaN.

图片

图片

After: How is it fixed in this PR?

pxSign will be part of the denominator somewhere else, so it shouldn't be 0

图片

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 10, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@yanheSu yanheSu changed the title fix(pictorialBar): fix linewidth NaN, when data is zero fix(pictorialBar): Fixed a problem with rendering incorrectly when data is 0 and borderWidth is set to a non-0 value Jun 10, 2020
@307590317
Copy link

307590317 commented Dec 10, 2020

这个bug什么时候会被修复?现在是12月10号,距离6月10号已经过去6个月了
When will this bug be fixed?Now is December 10th. It's been six months

@plainheart
Copy link
Member

Hi, @yanheSu Thanks for your contribution! I'm sorry for putting this matter on hold. Would you mind updating the codebase to the latest and resolving the conflicts?

@yanheSu
Copy link
Contributor Author

yanheSu commented Oct 27, 2021

Hi, @yanheSu Thanks for your contribution! I'm sorry for putting this matter on hold. Would you mind updating the codebase to the latest and resolving the conflicts?

Okay, I will switch to the latest code base, resolve the conflict and push again

@yanheSu yanheSu force-pushed the fix-pictorial-bar-data-zero-border branch from 3ab1341 to 140e0c3 Compare October 27, 2021 15:39
@yanheSu
Copy link
Contributor Author

yanheSu commented Oct 27, 2021

@plainheart I have updated the code and resolved the conflict, and added test cases, please review again

@yanheSu yanheSu requested a review from plainheart October 27, 2021 15:44
@plainheart plainheart added this to the 5.3 milestone Oct 28, 2021
@plainheart plainheart requested a review from pissang November 15, 2021 09:31
@yanheSu
Copy link
Contributor Author

yanheSu commented Dec 6, 2021

Is there any progress?
@plainheart

@plainheart
Copy link
Member

@yanheSu Waiting for the response from @pissang

@pissang pissang requested a review from 100pah December 7, 2021 05:47
@pissang
Copy link
Contributor

pissang commented Dec 7, 2021

LGTM.

@pissang pissang merged commit 2c57a9d into apache:master Dec 7, 2021
@echarts-bot
Copy link

echarts-bot bot commented Dec 7, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants