Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Add unit test for dubbo-registry-nacos #9035

Merged
merged 8 commits into from
Oct 14, 2021
Merged

[3.0] Add unit test for dubbo-registry-nacos #9035

merged 8 commits into from
Oct 14, 2021

Conversation

wangchengming666
Copy link
Member

Add unit test for dubbo-registry-nacos

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #9035 (409d857) into 3.0 (dcfd3ed) will increase coverage by 0.52%.
The diff coverage is 30.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9035      +/-   ##
============================================
+ Coverage     63.75%   64.28%   +0.52%     
- Complexity      313      314       +1     
============================================
  Files          1168     1168              
  Lines         50192    50193       +1     
  Branches       7465     7466       +1     
============================================
+ Hits          32001    32267     +266     
+ Misses        14703    14423     -280     
- Partials       3488     3503      +15     
Impacted Files Coverage Δ
...ubbo/registry/nacos/NacosNamingServiceWrapper.java 52.17% <0.00%> (+52.17%) ⬆️
...org/apache/dubbo/registry/nacos/NacosRegistry.java 51.77% <30.00%> (+51.77%) ⬆️
...o/registry/nacos/util/NacosInstanceManageUtil.java 75.00% <50.00%> (+75.00%) ⬆️
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (-6.90%) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 68.42% <0.00%> (-5.27%) ⬇️
.../registry/zookeeper/ZookeeperServiceDiscovery.java 83.33% <0.00%> (-2.39%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 70.23% <0.00%> (-1.20%) ⬇️
...ubbo/config/deploy/DefaultApplicationDeployer.java 79.19% <0.00%> (-0.45%) ⬇️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 69.03% <0.00%> (+0.32%) ⬆️
...ting/zookeeper/curator/CuratorZookeeperClient.java 71.35% <0.00%> (+0.97%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcfd3ed...409d857. Read the comment docs.

@wangchengming666 wangchengming666 marked this pull request as draft October 14, 2021 05:42
@wangchengming666 wangchengming666 marked this pull request as ready for review October 14, 2021 05:42
@AlbumenJ AlbumenJ merged commit 54b2096 into apache:3.0 Oct 14, 2021
@wangchengming666 wangchengming666 deleted the add-nacos-registry-test branch October 18, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants