Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Fix Listener early initialization #9006

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

stone-98
Copy link
Contributor

What is the purpose of the change

Fix #7896 on 3.0

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #9006 (2d8382c) into 3.0 (f561138) will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9006      +/-   ##
============================================
- Coverage     63.38%   63.33%   -0.06%     
- Complexity      314      315       +1     
============================================
  Files          1186     1187       +1     
  Lines         50358    50368      +10     
  Branches       7525     7526       +1     
============================================
- Hits          31920    31901      -19     
- Misses        14957    14989      +32     
+ Partials       3481     3478       -3     
Impacted Files Coverage Δ
...nfigBeanDefinitionConflictApplicationListener.java 34.37% <0.00%> (ø)
.../autoconfigure/DubboListenerAutoConfiguration.java 100.00% <100.00%> (ø)
.../context/event/WelcomeLogoApplicationListener.java 64.00% <0.00%> (-28.00%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 58.13% <0.00%> (-9.31%) ⬇️
.../common/threadpool/serial/SerializingExecutor.java 70.37% <0.00%> (-7.41%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...ntext/event/AwaitingNonWebApplicationListener.java 74.64% <0.00%> (-5.64%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 76.81% <0.00%> (-3.99%) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0.00%> (-1.89%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f561138...2d8382c. Read the comment docs.

@AlbumenJ AlbumenJ merged commit ee96155 into apache:3.0 Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants