Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] destroy executor and improve tests 0926 #8928

Merged

Conversation

kylixs
Copy link
Member

@kylixs kylixs commented Sep 26, 2021

What is the purpose of the change

  • Destroy executor services
  • dubbo-config-spring surefire plugin reuseForks=true
  • Fix unregister DubboShutdownHook error
  • Fix DecodeableRpcResult read config NPE
  • Improve registry center of tests: PropertySourcesInJavaConfigTest, JavaConfigReferenceBeanTest

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2021

Codecov Report

Merging #8928 (d9489c0) into 3.0 (bba0a76) will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8928      +/-   ##
============================================
+ Coverage     63.43%   63.48%   +0.04%     
  Complexity      315      315              
============================================
  Files          1180     1180              
  Lines         50062    50091      +29     
  Branches       7502     7506       +4     
============================================
+ Hits          31757    31799      +42     
+ Misses        14843    14831      -12     
+ Partials       3462     3461       -1     
Impacted Files Coverage Δ
...ava/org/apache/dubbo/config/DubboShutdownHook.java 60.60% <16.66%> (-20.88%) ⬇️
...java/org/apache/dubbo/rpc/cluster/RouterChain.java 78.72% <50.00%> (-0.54%) ⬇️
.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java 51.89% <50.00%> (+0.61%) ⬆️
.../threadpool/manager/DefaultExecutorRepository.java 73.91% <66.66%> (-0.51%) ⬇️
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 69.15% <0.00%> (-2.81%) ⬇️
.../rpc/protocol/dubbo/LazyConnectExchangeClient.java 55.91% <0.00%> (-2.33%) ⬇️
...pache/dubbo/remoting/transport/AbstractClient.java 63.57% <0.00%> (-2.15%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba0a76...d9489c0. Read the comment docs.

Copy link

@DiegoKrupitza DiegoKrupitza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

@AlbumenJ AlbumenJ merged commit 30d0fac into apache:3.0 Sep 28, 2021
@kylixs kylixs deleted the 3.0-destroy-executor-and-improve-tests-0926 branch October 23, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants