Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] add destroy() calling to close tomcat server port #8920

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 25, 2021

What is the purpose of the change

#8919

@zrlw zrlw changed the title add destroy() calling to close tomcat server port [3.0] add destroy() calling to close tomcat server port Sep 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #8920 (22173fd) into 3.0 (5fb4a50) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8920      +/-   ##
============================================
- Coverage     63.43%   63.41%   -0.03%     
+ Complexity      315      312       -3     
============================================
  Files          1180     1180              
  Lines         50061    50062       +1     
  Branches       7502     7502              
============================================
- Hits          31757    31746      -11     
- Misses        14842    14850       +8     
- Partials       3462     3466       +4     
Impacted Files Coverage Δ
...e/dubbo/remoting/http/tomcat/TomcatHttpServer.java 87.87% <100.00%> (+0.37%) ⬆️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (-6.90%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 70.23% <0.00%> (-1.20%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 88.39% <0.00%> (-0.90%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.72% <0.00%> (+0.34%) ⬆️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 63.10% <0.00%> (+0.97%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0.00%> (+1.98%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb4a50...22173fd. Read the comment docs.

@CrazyHZM CrazyHZM added type/bug Bugs to being fixed version/3.x labels Sep 26, 2021
Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit bba0a76 into apache:3.0 Sep 26, 2021
@zrlw zrlw deleted the patch-TomcatHttpServer branch February 17, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bugs to being fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants