Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Fix when subscribing, the check configuration section is unavailable(#8841) #8879

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

stone-98
Copy link
Contributor

What is the purpose of the change

Fix #8841 on 3.0

Copy link
Member

@BurningCN BurningCN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #8879 (cf5da3e) into 3.0 (9a0629c) will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8879      +/-   ##
============================================
+ Coverage     63.87%   63.91%   +0.04%     
  Complexity      314      314              
============================================
  Files          1169     1169              
  Lines         49239    49240       +1     
  Branches       7366     7366              
============================================
+ Hits          31450    31471      +21     
+ Misses        14368    14350      -18     
+ Partials       3421     3419       -2     
Impacted Files Coverage Δ
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 66.04% <66.66%> (+0.21%) ⬆️
...dubbo/remoting/exchange/support/DefaultFuture.java 88.28% <0.00%> (-4.51%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 63.04% <0.00%> (-4.35%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0.00%> (-1.00%) ⬇️
...a/org/apache/dubbo/rpc/model/ApplicationModel.java 79.60% <0.00%> (-0.66%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.12% <0.00%> (-0.20%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 61.16% <0.00%> (ø)
...etadata/report/support/AbstractMetadataReport.java 61.72% <0.00%> (+0.95%) ⬆️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 71.42% <0.00%> (+1.19%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0629c...cf5da3e. Read the comment docs.

@AlbumenJ AlbumenJ merged commit ab53b5a into apache:3.0 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When subscribing, the check configuration section is unavailable
4 participants