Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javaassist ClassPool ClassPath #8828

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #8828 (204561e) into 3.0 (b5190a6) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8828      +/-   ##
============================================
- Coverage     63.78%   63.64%   -0.14%     
- Complexity      314      315       +1     
============================================
  Files          1160     1160              
  Lines         48898    48860      -38     
  Branches       7331     7302      -29     
============================================
- Hits          31189    31099      -90     
- Misses        14288    14328      +40     
- Partials       3421     3433      +12     
Impacted Files Coverage Δ
...g/apache/dubbo/common/bytecode/ClassGenerator.java 62.43% <100.00%> (ø)
...java/org/apache/dubbo/common/bytecode/Wrapper.java 82.58% <100.00%> (ø)
.../dubbo/common/compiler/support/CtClassBuilder.java 60.71% <100.00%> (ø)
...ntext/event/AwaitingNonWebApplicationListener.java 60.56% <0.00%> (-22.54%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 68.96% <0.00%> (-13.80%) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 75.00% <0.00%> (-12.50%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 50.00% <0.00%> (-11.54%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-10.87%) ⬇️
...moting/transport/netty4/NettyEventLoopFactory.java 22.22% <0.00%> (-7.78%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5190a6...204561e. Read the comment docs.

@AlbumenJ AlbumenJ merged commit bcdd887 into apache:3.0 Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants