Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Refactor application/module deploy processing and events #8824

Merged
merged 15 commits into from
Sep 17, 2021

Conversation

kylixs
Copy link
Member

@kylixs kylixs commented Sep 16, 2021

What is the purpose of the change

  • Refactor application/module deploy processing and events, more clearer state.
  • Start and stop the bound dubbo module according to the spring context event, instead of controlling whole dubbo application.
  • Remove DubboBootstrap from dubbo-config-spring , add DubboSpringInitializationCustomizerHolder for register customizers by programing.
  • Split DubboShutdownHook and ShutdownHookCallback, adjust call chains.
  • Improve SpringExtensionInjector initialization

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #8824 (ab63644) into 3.0 (bcdd887) will decrease coverage by 0.02%.
The diff coverage is 73.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8824      +/-   ##
============================================
- Coverage     63.79%   63.76%   -0.03%     
+ Complexity      315      314       -1     
============================================
  Files          1161     1169       +8     
  Lines         48983    49196     +213     
  Branches       7334     7359      +25     
============================================
+ Hits          31248    31371     +123     
- Misses        14315    14399      +84     
- Partials       3420     3426       +6     
Impacted Files Coverage Δ
...java/org/apache/dubbo/common/bytecode/Wrapper.java 82.58% <ø> (ø)
...ava/org/apache/dubbo/config/ServiceConfigBase.java 61.01% <0.00%> (-1.27%) ⬇️
...ache/dubbo/config/ConfigScopeModelInitializer.java 100.00% <ø> (ø)
...ing/context/DubboBootstrapApplicationListener.java 0.00% <0.00%> (-61.12%) ⬇️
.../DubboBootstrapStartStopListenerSpringAdapter.java 42.85% <ø> (-57.15%) ⬇️
.../annotation/DubboConfigConfigurationRegistrar.java 100.00% <ø> (ø)
...pring/context/event/DubboBootstrapStatedEvent.java 0.00% <ø> (-66.67%) ⬇️
...pring/context/event/DubboBootstrapStopedEvent.java 0.00% <ø> (-66.67%) ⬇️
...fig/spring/context/event/DubboConfigInitEvent.java 66.66% <ø> (ø)
.../dubbo/metadata/report/MetadataReportInstance.java 84.84% <ø> (-0.45%) ⬇️
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcdd887...ab63644. Read the comment docs.

@AlbumenJ AlbumenJ merged commit afbeaaf into apache:3.0 Sep 17, 2021
@kylixs kylixs deleted the 3.0-customize-dubbo-init-context-0914 branch October 23, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants