Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Fix #8704, unify error message #8794

Merged
merged 5 commits into from
Sep 20, 2021
Merged

[3.0] Fix #8704, unify error message #8794

merged 5 commits into from
Sep 20, 2021

Conversation

wangchengming666
Copy link
Member

issue no #8704

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2021

Codecov Report

Merging #8794 (3a04ff5) into 3.0 (1702fa0) will increase coverage by 0.03%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8794      +/-   ##
============================================
+ Coverage     63.74%   63.78%   +0.03%     
- Complexity      313      314       +1     
============================================
  Files          1169     1169              
  Lines         49210    49205       -5     
  Branches       7360     7357       -3     
============================================
+ Hits          31370    31385      +15     
+ Misses        14412    14395      -17     
+ Partials       3428     3425       -3     
Impacted Files Coverage Δ
...ubbo/registry/client/ServiceDiscoveryRegistry.java 81.87% <66.66%> (-0.25%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 82.68% <100.00%> (+0.63%) ⬆️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 60.86% <0.00%> (-4.35%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 66.50% <0.00%> (-0.50%) ⬇️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 69.03% <0.00%> (+0.32%) ⬆️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 80.06% <0.00%> (+0.68%) ⬆️
...e/dubbo/remoting/transport/netty4/NettyClient.java 71.01% <0.00%> (+1.44%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0.00%> (+2.97%) ⬆️
.../apache/dubbo/remoting/transport/CodecSupport.java 83.07% <0.00%> (+3.07%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1702fa0...3a04ff5. Read the comment docs.

@BurningCN
Copy link
Member

pls fix conflicts

@wangchengming666
Copy link
Member Author

pls fix conflicts

done, thanks

# Conflicts:
#	dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/ServiceDiscoveryRegistry.java
# Conflicts:
#	dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/ServiceDiscoveryRegistry.java
@AlbumenJ AlbumenJ merged commit f291887 into apache:3.0 Sep 20, 2021
@wangchengming666 wangchengming666 deleted the fix-#8704 branch September 21, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants