Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Multi instance - multi module config/deploy and spring support #8789

Merged
merged 21 commits into from
Sep 14, 2021

Conversation

kylixs
Copy link
Member

@kylixs kylixs commented Sep 13, 2021

What is the purpose of the change

  • Extract ApplicationDeployer and ModuleDeployer from DubboBootstrap, support start/destroy module.
  • Extract ModuleConfigManager from ConfigManager
  • Remove DubboBootstrap ref from ReferenceConfig and ServiceConfig
  • DubboBootstrap.newInstance() is changed to share the default FrameworkModel
  • Add spring support for multi module.

@kylixs kylixs changed the title [3.0] Multi instance - multi module and spring support [3.0] Multi instance - multi module config/deploy and spring support Sep 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

Codecov Report

Merging #8789 (6c1774e) into 3.0 (675aead) will increase coverage by 0.00%.
The diff coverage is 69.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##                3.0    #8789    +/-   ##
==========================================
  Coverage     63.89%   63.90%            
  Complexity      313      313            
==========================================
  Files          1151     1156     +5     
  Lines         48381    48690   +309     
  Branches       7294     7323    +29     
==========================================
+ Hits          30914    31114   +200     
- Misses        14088    14181    +93     
- Partials       3379     3395    +16     
Impacted Files Coverage Δ
.../rpc/cluster/router/tag/TagDynamicStateRouter.java 32.67% <ø> (ø)
...o/rpc/cluster/router/tag/TagStaticStateRouter.java 59.52% <ø> (ø)
...g/apache/dubbo/common/bytecode/ClassGenerator.java 62.43% <ø> (ø)
...figcenter/file/FileSystemDynamicConfiguration.java 0.00% <0.00%> (ø)
.../dubbo/config/bootstrap/BootstrapTakeoverMode.java 100.00% <ø> (ø)
.../metadata/ConfigurableMetadataServiceExporter.java 86.15% <ø> (-0.21%) ⬇️
...g/apache/dubbo/config/spring/ConfigCenterBean.java 21.87% <ø> (-2.37%) ⬇️
.../org/apache/dubbo/config/spring/ReferenceBean.java 94.36% <ø> (ø)
...ring/context/event/DubboAnnotationInitedEvent.java 66.66% <0.00%> (-33.34%) ⬇️
...apache/dubbo/container/spring/SpringContainer.java 72.22% <ø> (ø)
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675aead...6c1774e. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 5c2161a into apache:3.0 Sep 14, 2021
@kylixs kylixs deleted the 3.0-multi-instance-multi-module-0908 branch October 23, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants