Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT: refer metadata service #8761

Merged
merged 8 commits into from
Sep 12, 2021

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@CrazyHZM CrazyHZM added this to the 3.0.3 milestone Sep 10, 2021
# Conflicts:
#	dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/metadata/MetadataUtils.java
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #8761 (a18d558) into 3.0 (b1ebfe8) will increase coverage by 0.12%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8761      +/-   ##
============================================
+ Coverage     63.63%   63.75%   +0.12%     
- Complexity      311      314       +3     
============================================
  Files          1149     1149              
  Lines         48283    48351      +68     
  Branches       7281     7292      +11     
============================================
+ Hits          30724    30826     +102     
+ Misses        14176    14152      -24     
+ Partials       3383     3373      -10     
Impacted Files Coverage Δ
.../dubbo/registry/client/DefaultServiceInstance.java 84.74% <ø> (ø)
.../dubbo/registry/client/metadata/MetadataUtils.java 85.71% <75.00%> (+0.42%) ⬆️
...metadata/SpringCloudMetadataServiceURLBuilder.java 100.00% <100.00%> (ø)
...bbo/common/threadlocal/InternalThreadLocalMap.java 74.02% <0.00%> (-15.17%) ⬇️
...va/org/apache/dubbo/remoting/exchange/Request.java 77.19% <0.00%> (-11.05%) ⬇️
...in/java/org/apache/dubbo/rpc/model/ScopeModel.java 59.09% <0.00%> (-6.30%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0.00%> (-1.00%) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 53.12% <0.00%> (-0.85%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 89.18% <0.00%> (-0.29%) ⬇️
...a/org/apache/dubbo/rpc/model/ApplicationModel.java 79.66% <0.00%> (-0.16%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ebfe8...a18d558. Read the comment docs.

@CrazyHZM CrazyHZM merged commit 27ef85c into apache:3.0 Sep 12, 2021
@CrazyHZM CrazyHZM deleted the 3.0_feature/ut_refer_metadata_service branch September 12, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants