Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Multi Instances Related Refactor #8737

Merged
merged 22 commits into from
Sep 10, 2021

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Sep 9, 2021

What is the purpose of the change

  • Refactor some ExtensionLoader usage
  • Introduce Initializer for ScopeModel
  • Add TCCL Changer
  • remove some default model usage
  • Remove Hessian2 TL

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ changed the title Refactor some ExtensionLoader usage & Introduce Initializer for ScopeModel [3.0] Multi Instances Related Refactor Sep 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #8737 (eafdd42) into 3.0 (09f1f9a) will decrease coverage by 0.09%.
The diff coverage is 77.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8737      +/-   ##
============================================
- Coverage     63.72%   63.63%   -0.10%     
  Complexity      312      312              
============================================
  Files          1145     1149       +4     
  Lines         48182    48285     +103     
  Branches       7254     7281      +27     
============================================
+ Hits          30706    30727      +21     
- Misses        14108    14177      +69     
- Partials       3368     3381      +13     
Impacted Files Coverage Δ
...bo/rpc/cluster/filter/support/ZoneAwareFilter.java 0.00% <0.00%> (ø)
...o/rpc/cluster/support/MergeableClusterInvoker.java 38.88% <0.00%> (-0.44%) ⬇️
...a/org/apache/dubbo/config/ReferenceConfigBase.java 70.54% <0.00%> (-0.56%) ⬇️
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 69.82% <ø> (-0.24%) ⬇️
...apache/dubbo/metadata/MetadataServiceExporter.java 33.33% <0.00%> (ø)
.../dubbo/registry/client/DefaultServiceInstance.java 84.74% <ø> (-1.70%) ⬇️
...ubbo/registry/client/ServiceDiscoveryRegistry.java 82.00% <0.00%> (ø)
...stry/integration/AbstractConfiguratorListener.java 41.30% <0.00%> (-2.89%) ⬇️
...org/apache/dubbo/registry/nacos/NacosRegistry.java 0.00% <0.00%> (ø)
...org/apache/dubbo/registry/xds/util/XdsChannel.java 0.00% <0.00%> (ø)
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f1f9a...eafdd42. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 1dfb114 into apache:3.0 Sep 10, 2021
@AlbumenJ AlbumenJ mentioned this pull request Oct 23, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants