Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add testcase to check exported service in multiple registry center #8598

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

pinxiong
Copy link
Member

What is the purpose of the change

Add testcase to check exported service in multiple registry center

Brief changelog

  1. Add testcases
  2. Update the tickTime to increase the timeout in dubbo-config-spring module

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

1. Add testcases
2. Update the tickTime to increase the timeout in dubbo-config-spring module
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #8598 (d020f28) into 3.0 (6689f4e) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8598      +/-   ##
============================================
+ Coverage     62.95%   63.01%   +0.05%     
- Complexity      310      313       +3     
============================================
  Files          1117     1117              
  Lines         46788    46788              
  Branches       7047     7047              
============================================
+ Hits          29457    29482      +25     
+ Misses        14038    14016      -22     
+ Partials       3293     3290       -3     
Impacted Files Coverage Δ
...keeper/ZookeeperServiceDiscoveryChangeWatcher.java 88.88% <0.00%> (-3.71%) ⬇️
...etadata/store/InMemoryWritableMetadataService.java 80.92% <0.00%> (-2.64%) ⬇️
...bo/remoting/zookeeper/AbstractZookeeperClient.java 81.60% <0.00%> (-2.30%) ⬇️
...stry/client/ServiceDiscoveryRegistryDirectory.java 46.41% <0.00%> (-0.96%) ⬇️
...vent/listener/ServiceInstancesChangedListener.java 77.72% <0.00%> (-0.50%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 79.20% <0.00%> (+0.20%) ⬆️
.../dubbo/registry/integration/RegistryDirectory.java 47.17% <0.00%> (+0.66%) ⬆️
...etadata/report/support/AbstractMetadataReport.java 61.72% <0.00%> (+0.95%) ⬆️
.../exchange/support/header/HeaderExchangeServer.java 68.86% <0.00%> (+1.88%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 79.92% <0.00%> (+3.28%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6689f4e...d020f28. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 24e4bd3 into apache:3.0 Aug 27, 2021
@pinxiong pinxiong deleted the export-service-multiple branch September 5, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants