Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Verify the mapping between exported provider and metadata #8510

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

pinxiong
Copy link
Member

What is the purpose of the change

Add testcases for checking the mapping between exported provider and metadata

Brief changelog

  1. Check if the exported service (provider) is registered
  2. Check if registered service (provider)'s name is right
  3. Check if registered service (provider)'s version exists

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #8510 (a929d9b) into 3.0 (7135164) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8510      +/-   ##
============================================
+ Coverage     63.01%   63.02%   +0.01%     
- Complexity      312      313       +1     
============================================
  Files          1117     1117              
  Lines         46789    46789              
  Branches       7047     7047              
============================================
+ Hits          29482    29490       +8     
+ Misses        14026    14022       -4     
+ Partials       3281     3277       -4     
Impacted Files Coverage Δ
...va/org/apache/dubbo/registry/RegistryNotifier.java 82.85% <0.00%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 62.85% <0.00%> (+1.42%) ⬆️
...e/dubbo/remoting/transport/netty/NettyChannel.java 60.22% <0.00%> (+4.54%) ⬆️
.../apache/dubbo/remoting/transport/AbstractPeer.java 69.56% <0.00%> (+6.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7135164...a929d9b. Read the comment docs.

@pinxiong pinxiong force-pushed the metadata-mapping branch 3 times, most recently from ea4af5f to 4731f9a Compare August 20, 2021 06:32
1. Check if the exported service (provider) is registered
2. Check if registered service (provider)'s name is right
3. Check if registered service (provider)'s version exists
@AlbumenJ AlbumenJ added this to the 3.0.3 milestone Aug 23, 2021
@chickenlj chickenlj merged commit 876eae7 into apache:3.0 Aug 25, 2021
@pinxiong pinxiong deleted the metadata-mapping branch August 25, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants