Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3.0 use triple can not return real exception #8458

Merged
merged 9 commits into from
Aug 11, 2021
Merged

Fix 3.0 use triple can not return real exception #8458

merged 9 commits into from
Aug 11, 2021

Conversation

EarthChen
Copy link
Member

What is the purpose of the change

fix dubbo 3.0 use triple can not return real exception #8363

Brief changelog

  • use hessian2 wrapper java exception
  • add common exception structure for multi-language

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@EarthChen EarthChen changed the title Fix/triple exception Fix 3.0 use triple can not return real exception Aug 9, 2021
@AlbumenJ
Copy link
Member

please fix compile error

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #8458 (cdc2c29) into 3.0 (4149543) will decrease coverage by 0.34%.
The diff coverage is 5.67%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8458      +/-   ##
============================================
- Coverage     63.20%   62.86%   -0.35%     
- Complexity      311      312       +1     
============================================
  Files          1099     1112      +13     
  Lines         46054    46633     +579     
  Branches       6956     7016      +60     
============================================
+ Hits          29109    29314     +205     
- Misses        13692    14056     +364     
- Partials       3253     3263      +10     
Impacted Files Coverage Δ
...e/dubbo/rpc/protocol/tri/AbstractServerStream.java 57.73% <0.00%> (ø)
...rg/apache/dubbo/rpc/protocol/tri/ClientStream.java 0.00% <0.00%> (ø)
...apache/dubbo/rpc/protocol/tri/DefaultMetadata.java 58.33% <0.00%> (-11.67%) ⬇️
.../apache/dubbo/rpc/protocol/tri/ExceptionUtils.java 0.00% <0.00%> (ø)
.../org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java 44.15% <0.00%> (-4.42%) ⬇️
...apache/dubbo/rpc/protocol/tri/Http2HeaderMeta.java 55.55% <0.00%> (-19.45%) ⬇️
...va/org/apache/dubbo/rpc/protocol/tri/Metadata.java 33.33% <ø> (ø)
...he/dubbo/rpc/protocol/tri/TripleClientHandler.java 54.54% <0.00%> (ø)
...che/dubbo/rpc/protocol/tri/TripleRpcException.java 0.00% <0.00%> (ø)
.../org/apache/dubbo/rpc/protocol/tri/TripleUtil.java 35.33% <0.00%> (-10.36%) ⬇️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4149543...cdc2c29. Read the comment docs.

@guohao guohao merged commit 6808f8f into apache:3.0 Aug 11, 2021
@AlbumenJ AlbumenJ added this to the 3.0.3 milestone Aug 15, 2021
@EarthChen EarthChen deleted the fix/triple-exception branch September 23, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants