Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] some statement can be simplified #10525

Merged
merged 1 commit into from
Sep 2, 2022
Merged

[fix] some statement can be simplified #10525

merged 1 commit into from
Sep 2, 2022

Conversation

llnancy
Copy link
Contributor

@llnancy llnancy commented Sep 1, 2022

What is the purpose of the change

make some 'if' statement be simplified and format code

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #10525 (7656871) into 3.1 (db210e0) will increase coverage by 0.06%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##                3.1   #10525      +/-   ##
============================================
+ Coverage     64.57%   64.64%   +0.06%     
  Complexity      396      396              
============================================
  Files          1331     1331              
  Lines         56548    56544       -4     
  Branches       8370     8368       -2     
============================================
+ Hits          36517    36553      +36     
+ Misses        16084    16042      -42     
- Partials       3947     3949       +2     
Impacted Files Coverage Δ
...bbo/rpc/cluster/loadbalance/RandomLoadBalance.java 74.19% <75.00%> (+8.47%) ⬆️
...he/dubbo/rpc/listener/ListenerExporterWrapper.java 68.00% <0.00%> (-20.00%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-6.90%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 66.97% <0.00%> (-3.67%) ⬇️
...ubbo/common/url/component/param/DynamicValues.java 78.12% <0.00%> (-3.13%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.09% <0.00%> (-2.39%) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 61.06% <0.00%> (-1.77%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 87.06% <0.00%> (-0.87%) ⬇️
...java/org/apache/dubbo/remoting/api/Connection.java 80.83% <0.00%> (-0.84%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 85.56% <0.00%> (-0.69%) ⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit e5b1caf into apache:3.1 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants