Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shade kubernetes and xds module #10514

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Shade kubernetes and xds module #10514

merged 1 commit into from
Sep 1, 2022

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2022

Codecov Report

Merging #10514 (e9984ff) into 3.1 (6fdc6a5) will decrease coverage by 1.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.1   #10514      +/-   ##
============================================
- Coverage     65.48%   64.44%   -1.05%     
- Complexity      318      335      +17     
============================================
  Files          1275     1325      +50     
  Lines         55045    56403    +1358     
  Branches       8297     8387      +90     
============================================
+ Hits          36048    36350     +302     
- Misses        15072    16106    +1034     
- Partials       3925     3947      +22     
Impacted Files Coverage Δ
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 73.80% <0.00%> (-4.77%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 69.09% <0.00%> (-2.28%) ⬇️
...ache/dubbo/common/utils/SerializeClassChecker.java 83.07% <0.00%> (-2.17%) ⬇️
...bo/registry/support/CacheableFailbackRegistry.java 77.64% <0.00%> (-1.77%) ⬇️
...ubbo/registry/client/AbstractServiceDiscovery.java 85.27% <0.00%> (-1.56%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 69.33% <0.00%> (-1.00%) ⬇️
...a/org/apache/dubbo/config/ReferenceConfigBase.java 62.22% <0.00%> (-0.66%) ⬇️
...vent/listener/ServiceInstancesChangedListener.java 76.73% <0.00%> (-0.41%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 74.18% <0.00%> (-0.16%) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 47.16% <0.00%> (-0.15%) ⬇️
... and 68 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants