Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ServiceBeanNameBuilder same version/group conflict (#10454) #10455

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

xiaomiusa87
Copy link
Contributor

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member

would you please add some test cases for this PR?

@xiaomiusa87
Copy link
Contributor Author

would you please add some test cases for this PR?

yes, Test case has been added to ServiceBeanNameBuilderTest.java
image

@AlbumenJ
Copy link
Member

image

Please fix failed uts.

@xiaomiusa87
Copy link
Contributor Author

image

Please fix failed uts.

I have submitted the code again. How can I perform the test again

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2022

Codecov Report

Merging #10455 (aea4455) into 3.0 (b3f533d) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0   #10455      +/-   ##
============================================
- Coverage     65.73%   65.65%   -0.08%     
+ Complexity      318      296      -22     
============================================
  Files          1235     1235              
  Lines         53916    53917       +1     
  Branches       8154     8154              
============================================
- Hits          35442    35400      -42     
- Misses        14617    14660      +43     
  Partials       3857     3857              
Impacted Files Coverage Δ
...ans/factory/annotation/ServiceBeanNameBuilder.java 100.00% <100.00%> (+10.71%) ⬆️
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
.../apache/dubbo/rpc/filter/ProfilerServerFilter.java 62.85% <0.00%> (-20.00%) ⬇️
...che/dubbo/registry/client/NopServiceDiscovery.java 44.44% <0.00%> (-11.12%) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 58.13% <0.00%> (-9.31%) ⬇️
...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java 70.19% <0.00%> (-6.74%) ⬇️
...registry/zookeeper/util/CuratorFrameworkUtils.java 70.00% <0.00%> (-4.45%) ⬇️
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 63.56% <0.00%> (-3.88%) ⬇️
.../registry/zookeeper/ZookeeperServiceDiscovery.java 68.35% <0.00%> (-2.54%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 74.21% <0.00%> (-2.44%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 438519c into apache:3.0 Aug 15, 2022
@AlbumenJ AlbumenJ added this to the 3.0.11 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants