-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Up dev issue#10388 #10414
Up dev issue#10388 #10414
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0 #10414 +/- ##
============================================
+ Coverage 65.66% 65.68% +0.02%
+ Complexity 319 295 -24
============================================
Files 1234 1238 +4
Lines 53916 53940 +24
Branches 8155 8155
============================================
+ Hits 35402 35429 +27
+ Misses 14664 14657 -7
- Partials 3850 3854 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
README.md
Outdated
Apache Dubbo is a high-performance, Java-based open-source RPC framework. Please visit the [official site](http://dubbo.apache.org) for | ||
the quick start guide and documentation, as well as the [wiki](https://github.com/apache/dubbo/wiki) for news, FAQ, and release notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change this line
* | ||
* @throws RejectException if there is no more memory | ||
*/ | ||
void reject(E e, MemorySafeLinkedBlockingQueue<E> queue); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MemorySafeLinkedBlockingQueue
=> Queue
would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is no more memory will be throw RejectException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it's better to change the signature of this function to void reject(E e, Queue<E> queue)
. The Rejector
here should not be coupled with actual queue types like MemorySafeLinkedBlockingQueue
.
public void setRejector(final Rejector<E> rejector) { | ||
this.rejector = rejector; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can the user change this field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* | ||
* @throws RejectException if there is no more memory | ||
*/ | ||
void reject(E e, MemorySafeLinkedBlockingQueue<E> queue); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it's better to change the signature of this function to void reject(E e, Queue<E> queue)
. The Rejector
here should not be coupled with actual queue types like MemorySafeLinkedBlockingQueue
.
ok |
What is the purpose of the change
fix #10388
Brief changelog
Verifying this change
Checklist