Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add final modifier for lock in FrameworkModel #10281

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

Trying-hc
Copy link
Contributor

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #10281 (9af7da6) into 3.0 (6c1e456) will decrease coverage by 0.20%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                3.0   #10281      +/-   ##
============================================
- Coverage     65.70%   65.50%   -0.21%     
+ Complexity      320      318       -2     
============================================
  Files          1233     1233              
  Lines         53730    53730              
  Branches       8111     8110       -1     
============================================
- Hits          35304    35195     -109     
- Misses        14589    14692     +103     
- Partials       3837     3843       +6     
Impacted Files Coverage Δ
...ava/org/apache/dubbo/rpc/model/FrameworkModel.java 91.44% <66.66%> (ø)
...dubbo/remoting/zookeeper/ZookeeperTransporter.java 55.55% <0.00%> (-33.34%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 43.47% <0.00%> (-27.06%) ⬇️
.../remoting/api/SingleProtocolConnectionManager.java 61.53% <0.00%> (-23.08%) ⬇️
...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java 70.19% <0.00%> (-10.58%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) ⬇️
.../common/threadpool/serial/SerializingExecutor.java 70.37% <0.00%> (-7.41%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 73.80% <0.00%> (-4.77%) ⬇️
.../dubbo/registry/client/metadata/MetadataUtils.java 67.32% <0.00%> (-3.97%) ⬇️
.../apache/dubbo/remoting/transport/CodecSupport.java 80.30% <0.00%> (-3.04%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c1e456...9af7da6. Read the comment docs.

@AlbumenJ AlbumenJ merged commit e707178 into apache:3.0 Jul 7, 2022
@AlbumenJ AlbumenJ added this to the 3.0.10 milestone Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants