Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Fix dependencies pom hibernate version #10270

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jul 5, 2022

What is the purpose of the change

Fix #10269
Related pr #9552

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ added this to the 3.0.10 milestone Jul 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.73%. Comparing base (90cef36) to head (75b5c9c).
Report is 106 commits behind head on 3.0.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.0   #10270      +/-   ##
============================================
+ Coverage     65.70%   65.73%   +0.02%     
  Complexity      297      297              
============================================
  Files          1233     1233              
  Lines         53712    53734      +22     
  Branches       8107     8111       +4     
============================================
+ Hits          35294    35324      +30     
+ Misses        14587    14576      -11     
- Partials       3831     3834       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 7a1239f into apache:3.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency pom miss hibernate_validator_new_version
3 participants