Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard code comment format. #10251

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Standard code comment format. #10251

merged 1 commit into from
Jul 1, 2022

Conversation

kefate
Copy link

@kefate kefate commented Jul 1, 2022

What is the purpose of the change

Standard code comment format.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #10251 (2881098) into master (7a0c805) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #10251      +/-   ##
============================================
+ Coverage     60.90%   60.98%   +0.07%     
- Complexity      445      449       +4     
============================================
  Files          1100     1100              
  Lines         44511    44511              
  Branches       6486     6486              
============================================
+ Hits          27109    27144      +35     
+ Misses        14435    14405      -30     
+ Partials       2967     2962       -5     
Impacted Files Coverage Δ
...n/java/org/apache/dubbo/common/utils/NetUtils.java 68.81% <ø> (ø)
...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java 7.07% <ø> (ø)
...ache/dubbo/qos/command/DefaultCommandExecutor.java 100.00% <ø> (ø)
...e/dubbo/registry/integration/DynamicDirectory.java 67.64% <ø> (ø)
...src/main/java/org/apache/dubbo/rpc/RpcContext.java 66.83% <ø> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 82.14% <ø> (ø)
...c/protocol/dubbo/ReferenceCountExchangeClient.java 63.33% <ø> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 88.28% <0.00%> (-0.91%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (ø)
...ting/zookeeper/curator/CuratorZookeeperClient.java 69.51% <0.00%> (+1.06%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0c805...2881098. Read the comment docs.

@AlbumenJ AlbumenJ merged commit bbcb26c into apache:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants