Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0]buildCuratorFramework method add zk digest acl support when use zk in… #10247

Merged

Conversation

sagexueqi
Copy link
Contributor

What is the purpose of the change

  1. CuratorFrameworkUtils#buildCuratorFramework add digest authorization support. If not set, can be throw NoAuth Exception when use instance discovery and zk node set acl

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.64%. Comparing base (d6a1ff4) to head (9597e7d).
Report is 111 commits behind head on 3.0.

Files with missing lines Patch % Lines
...registry/zookeeper/util/CuratorFrameworkUtils.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.0   #10247      +/-   ##
============================================
- Coverage     65.66%   65.64%   -0.03%     
- Complexity      296      319      +23     
============================================
  Files          1233     1233              
  Lines         53677    53680       +3     
  Branches       8098     8100       +2     
============================================
- Hits          35247    35237      -10     
- Misses        14609    14617       +8     
- Partials       3821     3826       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit a934502 into apache:3.0 Jul 1, 2022
@sagexueqi sagexueqi deleted the 3.0-zk-instance-discovery-support-digest branch July 1, 2022 08:31
@AlbumenJ AlbumenJ added this to the 3.0.10 milestone Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants