Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Fix switch logger NPE #10180

Merged
merged 2 commits into from
Jun 20, 2022
Merged

[3.0] Fix switch logger NPE #10180

merged 2 commits into from
Jun 20, 2022

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ marked this pull request as ready for review June 20, 2022 07:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #10180 (f683cf0) into 3.0 (23f517a) will decrease coverage by 0.13%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##                3.0   #10180      +/-   ##
============================================
- Coverage     65.82%   65.69%   -0.14%     
  Complexity      319      319              
============================================
  Files          1231     1231              
  Lines         53556    53560       +4     
  Branches       8091     8091              
============================================
- Hits          35252    35184      -68     
- Misses        14469    14538      +69     
- Partials       3835     3838       +3     
Impacted Files Coverage Δ
...rg/apache/dubbo/qos/command/impl/SwitchLogger.java 33.33% <60.00%> (+13.33%) ⬆️
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
.../apache/dubbo/rpc/filter/ProfilerServerFilter.java 62.85% <0.00%> (-20.00%) ⬇️
...che/dubbo/registry/client/NopServiceDiscovery.java 44.44% <0.00%> (-11.12%) ⬇️
...mmon/threadpool/support/AbortPolicyWithReport.java 73.68% <0.00%> (-10.53%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 69.04% <0.00%> (-9.53%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 58.33% <0.00%> (-8.34%) ⬇️
...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java 70.19% <0.00%> (-6.74%) ⬇️
...ava/org/apache/dubbo/rpc/proxy/InvocationUtil.java 84.84% <0.00%> (-6.07%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f517a...f683cf0. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 0089503 into apache:3.0 Jun 20, 2022
@AlbumenJ AlbumenJ added this to the 3.0.10 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants