Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10031, separate configurators, routers notification from address notification. #10161

Merged

Conversation

chickenlj
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #10161 (7db1eee) into 3.0 (89863e0) will decrease coverage by 0.05%.
The diff coverage is 78.26%.

@@             Coverage Diff              @@
##                3.0   #10161      +/-   ##
============================================
- Coverage     65.68%   65.63%   -0.06%     
  Complexity      320      320              
============================================
  Files          1224     1224              
  Lines         53413    53419       +6     
  Branches       8077     8078       +1     
============================================
- Hits          35086    35063      -23     
- Misses        14508    14528      +20     
- Partials       3819     3828       +9     
Impacted Files Coverage Δ
...va/org/apache/dubbo/registry/RegistryNotifier.java 79.48% <ø> (-2.57%) ⬇️
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 65.31% <78.26%> (+0.04%) ⬆️
.../remoting/api/SingleProtocolConnectionManager.java 61.53% <0.00%> (-23.08%) ⬇️
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
.../apache/dubbo/rpc/filter/ProfilerServerFilter.java 62.85% <0.00%> (-20.00%) ⬇️
.../dubbo/rpc/protocol/tri/command/QueuedCommand.java 64.28% <0.00%> (-14.29%) ⬇️
...che/dubbo/registry/client/NopServiceDiscovery.java 44.44% <0.00%> (-11.12%) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 70.00% <0.00%> (-5.00%) ⬇️
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 63.56% <0.00%> (-3.88%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89863e0...7db1eee. Read the comment docs.

@chickenlj chickenlj requested a review from AlbumenJ June 15, 2022 08:26
@AlbumenJ AlbumenJ merged commit 14d8931 into apache:3.0 Jun 17, 2022
@AlbumenJ AlbumenJ added this to the 3.0.9 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants