Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Add safe foreach in RpcInvocation & Revert synchronizedMap in RpcInvocation #10160

Merged
merged 3 commits into from
Jun 15, 2022

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jun 15, 2022

Fix issue #10078.

For multi-language implementation Interoperability purposes, changing HashMap to any other Map implementations (#10139) is not approachable, because HashMap (the attachment) will be passed directly on the wire so if we did that other SDKs won't be able to decode.

@chickenlj
Copy link
Contributor

This change looks good to me.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Attention: Patch coverage is 58.97436% with 48 lines in your changes missing coverage. Please review.

Project coverage is 65.73%. Comparing base (64a96c5) to head (cd52a56).
Report is 135 commits behind head on 3.0.

Files with missing lines Patch % Lines
.../main/java/org/apache/dubbo/rpc/RpcInvocation.java 56.32% 30 Missing and 8 partials ⚠️
...rc/main/java/com/alibaba/dubbo/rpc/Invocation.java 0.00% 3 Missing ⚠️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 70.00% 3 Missing ⚠️
...org/apache/dubbo/rpc/filter/TokenHeaderFilter.java 0.00% 1 Missing ⚠️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 0.00% 0 Missing and 1 partial ⚠️
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 50.00% 1 Missing ⚠️
...g/apache/dubbo/rpc/protocol/tri/TripleInvoker.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.0   #10160      +/-   ##
============================================
+ Coverage     65.68%   65.73%   +0.05%     
- Complexity      297      320      +23     
============================================
  Files          1224     1224              
  Lines         53325    53355      +30     
  Branches       8062     8069       +7     
============================================
+ Hits          35025    35075      +50     
+ Misses        14480    14462      -18     
+ Partials       3820     3818       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyHZM CrazyHZM merged commit 89863e0 into apache:3.0 Jun 15, 2022
@AlbumenJ AlbumenJ added this to the 3.0.9 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants