Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization code #10158

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Optimization code #10158

merged 4 commits into from
Jun 27, 2022

Conversation

hdyztmdqd
Copy link
Contributor

@hdyztmdqd hdyztmdqd commented Jun 14, 2022

What is the purpose of the change

Optimization code

1.Use StringBuilder#append(Char) to improve performance
2.Replace runnable with lambda
3.The original implementation calls the get method twice.Replace it with computeIfAbsent.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

nanaa2019 and others added 4 commits June 14, 2022 21:00
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Attention: Patch coverage is 61.40351% with 22 lines in your changes missing coverage. Please review.

Project coverage is 65.64%. Comparing base (89863e0) to head (c7ae4e5).
Report is 133 commits behind head on 3.0.

Files with missing lines Patch % Lines
...va/org/apache/dubbo/common/utils/ExecutorUtil.java 44.44% 4 Missing and 1 partial ⚠️
...etadata/report/support/AbstractMetadataReport.java 55.55% 3 Missing and 1 partial ⚠️
...he/dubbo/qos/server/handler/QosProcessHandler.java 0.00% 4 Missing ⚠️
...he/dubbo/registry/multicast/MulticastRegistry.java 25.00% 3 Missing ⚠️
...apache/dubbo/common/extension/ExtensionLoader.java 85.71% 2 Missing ⚠️
.../rpc/cluster/router/state/RouterGroupingState.java 0.00% 1 Missing ⚠️
...ache/dubbo/qos/command/impl/GetRouterSnapshot.java 0.00% 1 Missing ⚠️
.../dubbo/remoting/http/jetty/JettyLoggerAdapter.java 0.00% 1 Missing ⚠️
.../org/apache/dubbo/test/check/DubboTestChecker.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.0   #10158      +/-   ##
============================================
- Coverage     65.68%   65.64%   -0.04%     
+ Complexity      320      319       -1     
============================================
  Files          1224     1224              
  Lines         53413    53415       +2     
  Branches       8077     8074       -3     
============================================
- Hits          35086    35066      -20     
- Misses        14508    14532      +24     
+ Partials       3819     3817       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 06cb5cd into apache:3.0 Jun 27, 2022
@AlbumenJ AlbumenJ added this to the 3.0.10 milestone Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants