Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve:speed up application start up time #10109

Merged
merged 7 commits into from
Jun 13, 2022

Conversation

qinliujie
Copy link
Contributor

What is the purpose of the change

speed up application start up time when application have many classloaders

Brief changelog

some spi are implements by dubbo framework only and scan multi classloaders resources may cause application startup very slow,so add properties file to determine which spi should be load only dubbo framework classloader

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Attention: Patch coverage is 72.59259% with 37 lines in your changes missing coverage. Please review.

Project coverage is 65.81%. Comparing base (4689fef) to head (70da952).
Report is 152 commits behind head on 3.0.

Files with missing lines Patch % Lines
...apache/dubbo/common/extension/ExtensionLoader.java 77.19% 15 Missing and 11 partials ⚠️
...n/java/org/apache/dubbo/config/AbstractConfig.java 11.11% 7 Missing and 1 partial ⚠️
...java/org/apache/dubbo/common/utils/FieldUtils.java 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.0   #10109      +/-   ##
============================================
+ Coverage     65.74%   65.81%   +0.07%     
  Complexity      320      320              
============================================
  Files          1220     1220              
  Lines         53144    53230      +86     
  Branches       8057     8078      +21     
============================================
+ Hits          34937    35033      +96     
+ Misses        14393    14378      -15     
- Partials       3814     3819       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ requested a review from chickenlj June 7, 2022 10:59
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit f7bf43b into apache:3.0 Jun 13, 2022
@AlbumenJ AlbumenJ added this to the 3.0.9 milestone Jun 20, 2022
guohao pushed a commit to guohao/dubbo that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants