Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix metadata service export port incorrect issue #10055

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

YoungHu
Copy link
Contributor

@YoungHu YoungHu commented May 18, 2022

What is the purpose of the change

fix #10054

Brief changelog

use dubbo protocol port as metadata service default export port

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #10055 (ace497c) into 3.0 (dec5dc3) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0   #10055      +/-   ##
============================================
- Coverage     65.73%   65.63%   -0.10%     
- Complexity      296      318      +22     
============================================
  Files          1220     1220              
  Lines         53138    53143       +5     
  Branches       8056     8058       +2     
============================================
- Hits          34932    34883      -49     
- Misses        14397    14445      +48     
- Partials       3809     3815       +6     
Impacted Files Coverage Δ
.../metadata/ConfigurableMetadataServiceExporter.java 79.77% <100.00%> (+3.58%) ⬆️
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) ⬇️
...mmon/threadpool/support/AbortPolicyWithReport.java 73.68% <0.00%> (-10.53%) ⬇️
...ava/org/apache/dubbo/rpc/proxy/InvocationUtil.java 81.81% <0.00%> (-9.10%) ⬇️
...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java 73.14% <0.00%> (-6.49%) ⬇️
...he/dubbo/remoting/transport/netty/NettyHelper.java 29.03% <0.00%> (-6.46%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 73.80% <0.00%> (-4.77%) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 57.14% <0.00%> (-4.29%) ⬇️
...ubbo/common/url/component/param/DynamicValues.java 79.16% <0.00%> (-4.17%) ⬇️
...ubbo/registry/client/AbstractServiceDiscovery.java 81.81% <0.00%> (-3.31%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec5dc3...ace497c. Read the comment docs.

@owen200008
Copy link
Contributor

owen200008 commented Jul 7, 2022

image
same error, metadata use 20880

@owen200008
Copy link
Contributor

use dubbo.application.metadata-service-port=31052 ?

@AlbumenJ
Copy link
Member

AlbumenJ commented Jul 8, 2022

use dubbo.application.metadata-service-port=31052 ?

After apply this PR?

@owen200008
Copy link
Contributor

use dubbo.application.metadata-service-port=31052 ?

After apply this PR?

no, i use version 3.0.9

@owen200008
Copy link
Contributor

use dubbo.application.metadata-service-port=31052 ?

After apply this PR?

i support throw exception when no config the metadata-service-port, not use the default or hide

@chickenlj chickenlj added this to the 3.0.10 milestone Jul 15, 2022
@chickenlj chickenlj merged commit 3101a5d into apache:3.0 Jul 15, 2022
win120a pushed a commit to win120a/dubbo that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.0] metadata export port diff with service export port
6 participants