Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] fix #9962, recreate RpcInvocation in BroadcastClusterInvoker #10027

Merged
merged 5 commits into from
Jun 13, 2022
Merged

[3.0] fix #9962, recreate RpcInvocation in BroadcastClusterInvoker #10027

merged 5 commits into from
Jun 13, 2022

Conversation

wangchengming666
Copy link
Member

@wangchengming666 wangchengming666 commented May 11, 2022

What is the purpose of the change

fix #9962

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #10027 (0974467) into 3.0 (c1c9aa8) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##                3.0   #10027      +/-   ##
============================================
+ Coverage     65.77%   65.78%   +0.01%     
  Complexity      320      320              
============================================
  Files          1220     1220              
  Lines         53115    53118       +3     
  Branches       8050     8051       +1     
============================================
+ Hits          34936    34945       +9     
+ Misses        14381    14372       -9     
- Partials       3798     3801       +3     
Impacted Files Coverage Δ
.../main/java/org/apache/dubbo/rpc/RpcInvocation.java 66.50% <50.00%> (+0.16%) ⬆️
...o/rpc/cluster/support/BroadcastClusterInvoker.java 59.18% <100.00%> (+1.73%) ⬆️
.../apache/dubbo/rpc/filter/ProfilerServerFilter.java 62.85% <0.00%> (-20.00%) ⬇️
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 69.09% <0.00%> (-4.55%) ⬇️
...ubbo/registry/client/AbstractServiceDiscovery.java 83.47% <0.00%> (-1.66%) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 59.36% <0.00%> (-0.64%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 85.22% <0.00%> (-0.35%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 76.61% <0.00%> (+0.33%) ⬆️
...ubbo/registry/client/ServiceDiscoveryRegistry.java 76.79% <0.00%> (+0.55%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c9aa8...0974467. Read the comment docs.

@chickenlj chickenlj added this to the 3.0.9 milestone May 12, 2022
wangchengming666 and others added 4 commits June 13, 2022 10:52
# Conflicts:
#	dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/RpcInvocation.java
# Conflicts:
#	dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/RpcInvocation.java
@chickenlj chickenlj merged commit 6d188d8 into apache:3.0 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.7.12 集群模式调用下的Invalid token
3 participants