-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failback容错模式下,设置重试次数为0,依旧会重试一次 #8715
Comments
I'll fix it later. |
icankeep
added a commit
to icankeep/dubbo
that referenced
this issue
Sep 8, 2021
8 tasks
8 tasks
AlbumenJ
pushed a commit
that referenced
this issue
Sep 11, 2021
set retries is zero ,finaly it's default? 改了,最后还是没改? |
这是构造方法的逻辑呀,我改的是run方法里的逻辑,显然不会又设置为DEFAULT_FAILBACK_TIMES呀 |
see #9526 |
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Steps to reproduce this issue
review代码时发现failback模式下的retries判断有问题。
调用失败时,没有判断重试次数,就直接加到了timer中。
timer中执行时,如果抛出异常,才判断如果超过重试次数,不继续进行。

Pls. provide [GitHub address] to reproduce this issue.
Expected Result
加到timer中之前就需要判断一次retries
Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
The text was updated successfully, but these errors were encountered: