Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cond optimization]Behavior of annotations and xml config should keep consistent #3357

Closed
tswstarplanet opened this issue Jan 25, 2019 · 2 comments
Assignees

Comments

@tswstarplanet
Copy link
Contributor

I found some corresponding annotation and xml config have inconsistent behavior.
What I mean is that some required properties in xml config are not required in comparable annotation configs. For example, the interface property is required in <dubbo:service /> config. But interfaceClass or interfaceName of @service annotation is not required.
I think it is not a good design. We should make them have consistent behavior because it can make processing of config clearer and simpler.

@mercyblitz
Copy link
Contributor

The related issue : apache/dubbo-spring-boot-project#382

@mercyblitz
Copy link
Contributor

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants