Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java9 in CI build #1521

Closed
htynkn opened this issue Mar 28, 2018 · 7 comments · Fixed by #1575
Closed

Add java9 in CI build #1521

htynkn opened this issue Mar 28, 2018 · 7 comments · Fixed by #1575

Comments

@htynkn
Copy link
Member

htynkn commented Mar 28, 2018

Currently dubbo support java6, java7 and java8.

All unit test pass in java9, we should consider add official support for java9 and even java10.
Currently travis support java9. java10 is in progress (travis-ci/travis-ci#9368)

As discussed in mail list, the first step is to add java9 in travis ci.

@htynkn
Copy link
Member Author

htynkn commented Mar 28, 2018

Additional informaiton:
[x]All unit test can pass in java9
[x]All javadoc generate pass in java9
[] cobertura-maven-plugin doesn't work with java9

Refer to build logs: https://api.travis-ci.org/v3/job/359231113/log.txt

@lovepoem
Copy link
Member

Now cobertura-maven-plugin is used to count the unit test coverage,we should ensure it can work

@htynkn
Copy link
Member Author

htynkn commented Mar 29, 2018

@lovepoem cobertura reply on com.sun:tools:jar which java9 removed (http://openjdk.java.net/jeps/220).

I don't think cobertura is in maintain any more. Latest release is at 2015 (http://mvnrepository.com/artifact/net.sourceforge.cobertura/cobertura)

@lovepoem
Copy link
Member

I don't think cobertura is in maintain any more. Latest release is at 2015

If so, we can consider other tools:such as coverails……

@lovepoem
Copy link
Member

Now the java9 ci faild: #1611

@lovepoem lovepoem reopened this Apr 21, 2018
@htynkn
Copy link
Member Author

htynkn commented Apr 22, 2018

@lovepoem hey Xin, I figure out the reason for issue 1611. Please refer to my comment for that PR.
The issue for PR 1611 is not related to java9 travis configuration and maven-javadoc-plugin is latest version. I couldn't see much we can improve for travis CI configuration.
Could you close this issue now or after 1611 merged?

@lovepoem
Copy link
Member

https://github.com/apache/maven-javadoc-plugin has resoled the issue in snapshot version, so we should pay attention to https://issues.apache.org/jira/projects/MJAVADOC/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants