[3.0] ignore non-dubbo nacos services (#8573)

apache · Aug 27, 2021 · bce9641 · bce9641
1 parent 24e4bd3
commit bce9641
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/...try/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java b/...try/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java
@@ -30,6 +30,7 @@
 import org.apache.dubbo.registry.RegistryNotifier;
 import org.apache.dubbo.registry.nacos.util.NacosInstanceManageUtil;
 import org.apache.dubbo.registry.support.FailbackRegistry;
+import org.apache.dubbo.rpc.RpcException;
 
 import com.alibaba.nacos.api.common.Constants;
 import com.alibaba.nacos.api.exception.NacosException;
@@ -39,7 +40,6 @@
 import com.alibaba.nacos.api.naming.pojo.Instance;
 import com.alibaba.nacos.api.naming.pojo.ListView;
 import com.google.common.collect.Lists;
-import org.apache.dubbo.rpc.RpcException;
 
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -69,6 +69,7 @@
 import static org.apache.dubbo.common.constants.RegistryConstants.PROVIDERS_CATEGORY;
 import static org.apache.dubbo.common.constants.RegistryConstants.ROUTERS_CATEGORY;
 import static org.apache.dubbo.registry.Constants.ADMIN_PROTOCOL;
+import static org.apache.dubbo.registry.nacos.NacosServiceName.NAME_SEPARATOR;
 import static org.apache.dubbo.registry.nacos.NacosServiceName.valueOf;
 
 /**
@@ -307,6 +308,7 @@ private Set<String> filterServiceNames(NacosServiceName serviceName) {
             serviceNames.addAll(namingService.getServicesOfServer(1, Integer.MAX_VALUE,
                 getUrl().getGroup(Constants.DEFAULT_GROUP)).getData()
                 .stream()
+                .filter(this::isConformRules)
                 .map(NacosServiceName::new)
                 .filter(serviceName::isCompatible)
                 .map(NacosServiceName::toString)
@@ -317,6 +319,18 @@ private Set<String> filterServiceNames(NacosServiceName serviceName) {
         }
     }
 
+    /**
+     * Verify whether it is a dubbo service
+     *
+     * @param serviceName
+     * @return
+     * @since 2.7.12
+     */
+    private boolean isConformRules(String serviceName) {
+        return serviceName.split(NAME_SEPARATOR, -1).length == 4;
+    }
+
+
     /**
      * Get the legacy subscribed service name for compatible with Dubbo 2.7.3 and below
      *