Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URL.String() data race panic #944

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Conversation

georgehao
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@georgehao georgehao changed the title fix: fix URL.String() data race panic fix: URL.String() data race panic Dec 19, 2020
@codecov-io
Copy link

codecov-io commented Dec 19, 2020

Codecov Report

Merging #944 (5683e9f) into develop (ce90b4b) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #944      +/-   ##
===========================================
+ Coverage    60.19%   60.24%   +0.05%     
===========================================
  Files          260      260              
  Lines        12884    12886       +2     
===========================================
+ Hits          7755     7763       +8     
+ Misses        4172     4166       -6     
  Partials       957      957              
Impacted Files Coverage Δ
common/url.go 59.62% <100.00%> (+0.25%) ⬆️
cluster/router/chain/chain.go 68.54% <0.00%> (-1.62%) ⬇️
remoting/getty/listener.go 41.62% <0.00%> (+0.54%) ⬆️
remoting/getty/pool.go 71.36% <0.00%> (+1.76%) ⬆️
remoting/kubernetes/listener.go 53.68% <0.00%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce90b4b...5683e9f. Read the comment docs.

Copy link
Contributor

@cityiron cityiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I found this class import cm "github.com/Workiva/go-datastructures/common" is in first package part, you can move to second.

@zouyx zouyx added this to the v1.5.5 milestone Dec 20, 2020
@zouyx zouyx added the bug Something isn't working label Dec 20, 2020
@zouyx zouyx merged commit f244915 into apache:develop Dec 20, 2020
zouyx added a commit that referenced this pull request Dec 20, 2020
fix:  URL.String() data race panic
zouyx added a commit that referenced this pull request Jan 4, 2021
fix:  URL.String() data race panic
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
fix:  URL.String() data race panic
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
fix:  URL.String() data race panic
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
fix:  URL.String() data race panic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants