Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp: get local ip once and reused it #808

Merged
merged 4 commits into from
Oct 28, 2020

Conversation

cvictory
Copy link
Contributor

As the title mentioned.

@cvictory cvictory changed the base branch from master to develop October 27, 2020 05:20
@codecov-io
Copy link

Codecov Report

Merging #808 into develop will increase coverage by 0.05%.
The diff coverage is 46.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #808      +/-   ##
===========================================
+ Coverage    59.92%   59.97%   +0.05%     
===========================================
  Files          259      260       +1     
  Lines        12752    12756       +4     
===========================================
+ Hits          7642     7651       +9     
+ Misses        4158     4149       -9     
- Partials       952      956       +4     
Impacted Files Coverage Δ
cluster/cluster_impl/base_cluster_invoker.go 66.66% <0.00%> (ø)
config/config_loader.go 53.15% <0.00%> (ø)
config_center/configurator/override.go 72.22% <0.00%> (ø)
registry/consul/utils.go 67.50% <0.00%> (ø)
common/host_util.go 50.00% <50.00%> (ø)
cluster/cluster_impl/failover_cluster_invoker.go 70.00% <100.00%> (ø)
cluster/router/condition/router.go 78.91% <100.00%> (ø)
registry/directory/directory.go 74.01% <100.00%> (ø)
registry/kubernetes/registry.go 60.86% <100.00%> (ø)
registry/nacos/registry.go 50.74% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec8195...04bb28d. Read the comment docs.

@AlexStocks AlexStocks changed the title when it need local ip, it will get it every time. We can get local ip once, and reused it. Imp: get local ip once and reused it Oct 27, 2020
@cvictory cvictory requested a review from watermelo October 27, 2020 13:17
@watermelo watermelo merged commit 0384e20 into apache:develop Oct 28, 2020
@zouyx zouyx added this to the v1.5.5 milestone Oct 30, 2020
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Imp: get local ip once and reused it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants